On Wed, Apr 25, 2018 at 12:13:07AM +0000, Kuninori Morimoto wrote: > > Hi Geert > > Thank for your review. > > > >> > CONFIG_SND_AUDIO_GRAPH_CARD is needed to use HDMI sound with video > > >> > > > >> > Signed-off-by: Kuninori Morimoto <[email protected]> > > >> > Tested-by: Nguyen Viet Dung <[email protected]> > > >> > > >> Thanks for your patch! > > >> > > >> > --- a/arch/arm64/configs/defconfig > > >> > +++ b/arch/arm64/configs/defconfig > > >> > @@ -440,6 +440,7 @@ CONFIG_SND_SOC_SAMSUNG=y > > >> > CONFIG_SND_SOC_RCAR=m > > >> > CONFIG_SND_SOC_AK4613=m > > >> > CONFIG_SND_SIMPLE_CARD=y > > >> > +CONFIG_SND_AUDIO_GRAPH_CARD=y > > >> > > >> Perhaps "m"? > > > > > > Do you suggest the same for renesas_defconfig? > > > That is, patch 2/10? > > > > No. For {shmobile,renesas}_defconfig we make everything builtin. > > For {multi_v7,arm64}_defconfig, we usually make non-critical devices > > modular. > > Yeah. > CONFIG_SND_AUDIO_GRAPH_CARD is similar driver to CONFIG_SND_SIMPLE_CARD > But it has =y on defconfig, thus, I used same style. > If it should be =m, then, we need +1 patch which modifes > CONFIG_SND_SIMPLE_CARD, too.
I think that would be ideal.
