On Fri, May 11, 2018 at 01:31:19PM +0900, Yoshihiro Shimoda wrote:
> This patch adds GPIO nodes for r8a77990 (R-Car E3).
> 
> Based on a patch from Takeshi Kihara <[email protected]>
> 
> Signed-off-by: Yoshihiro Shimoda <[email protected]>
> ---
>  arch/arm64/boot/dts/renesas/r8a77990.dtsi | 112 
> ++++++++++++++++++++++++++++++
>  1 file changed, 112 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi 
> b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> index efc3c0b..d94e047 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> @@ -60,6 +60,118 @@
>               #size-cells = <2>;
>               ranges;
>  
> +             gpio0: gpio@e6050000 {
> +                     compatible = "renesas,gpio-r8a77990",
> +                                  "renesas,rcar-gen3-gpio",
> +                                  "renesas,gpio-rcar";

"renesas,gpio-rcar" is deprecated and thus should not be added to DT any
more. I will see about removing it from r8a77995.dtsi which seems to be the
only place that it used in mainline.

Otherwise this patch looks good to me.

> +                     reg = <0 0xe6050000 0 0x50>;
> +                     interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
> +                     #gpio-cells = <2>;
> +                     gpio-controller;
> +                     gpio-ranges = <&pfc 0 0 18>;
> +                     #interrupt-cells = <2>;
> +                     interrupt-controller;
> +                     clocks = <&cpg CPG_MOD 912>;
> +                     power-domains = <&sysc 32>;
> +                     resets = <&cpg 912>;
> +             };

...

Reply via email to