On Tue, May 22, 2018 at 06:44:59PM +0300, Sergei Shtylyov wrote:
> On 05/22/2018 02:48 PM, Geert Uytterhoeven wrote:
>
> >> Define the generic R8A77980 part of the GEther device node.
> >>
> >> Based on the original (and large) patch by Vladimir Barinov.
> >>
> >> Signed-off-by: Vladimir Barinov <[email protected]>
> >> Signed-off-by: Sergei Shtylyov <[email protected]>
> >
> > Thanks for your patch!
> >
> > With the below addressed:
> > Reviewed-by: Geert Uytterhoeven <[email protected]>
>
> Thanks!
>
> >> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> >> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> >> @@ -417,6 +417,17 @@
> >> dma-channels = <16>;
> >> };
> >>
> >> + gether: ethernet@e7400000 {
> >> + compatible = "renesas,gether-r8a77980";
> >> + reg = <0 0xe7400000 0 0x1000>;
> >> + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
> >> + clocks = <&cpg CPG_MOD 813>;
> >> + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
> >
> > resets = <&cpg 813>;
>
> As usual...
>
> >
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> + status = "disabled";
> >
> > Any default phy-mode needed?
>
> A default "phy-mode" IMO make sense when the MAC supports a single
> PHY interface mode. In this case, both RMII and RGMII are supported, so
> I coulsn't choose a default...
I would think making an arbitrary choice is better than no choice.
How does the driver behave in the absence of a default?
>
> >> + };
> >> +
> >> mmc0: mmc@ee140000 {
> >> compatible = "renesas,sdhi-r8a77980",
> >> "renesas,rcar-gen3-sdhi";
> >
> >
> > Gr{oetje,eeting}s,
> >
> > Geert
> >
>
