On Wed, May 23, 2018 at 12:52:20PM +0200, Marek Vasut wrote: > The rcar_pcie_enable_msi() creates IRQ mappings using irq_create_mapping() > before requesting the IRQs using devm_request_irq(). If devm_request_irq() > fails for some reason, rcar_pcie_enable_msi() does not remove the mapping. > > Pull out the code for disposing IRQ mappings from rcar_pcie_teardown_msi() > into a separate function and call it from both rcar_pcie_teardown_msi() > and rcar_pcie_enable_msi() failpath to remove the mappings correctly. > > Signed-off-by: Marek Vasut <[email protected]> > Reported-by: Geert Uytterhoeven <[email protected]> > Cc: Geert Uytterhoeven <[email protected]> > Cc: Phil Edworthy <[email protected]> > Cc: Simon Horman <[email protected]> > Cc: Wolfram Sang <[email protected]> > Cc: [email protected]
Reviewed-by: Simon Horman <[email protected]>
