Hi Simon, On Wed, Jun 6, 2018 at 10:52 AM, Simon Horman <[email protected]> wrote: > On Tue, Jun 05, 2018 at 05:05:15PM +0200, Geert Uytterhoeven wrote: >> The quirk for R-Car E3 ES1.0 added in commit 086b399965a7ee7e ("soc: >> renesas: r8a77990-sysc: Add workaround for 3DG-{A,B}") makes the 3DG-A >> PM domain a subdomain of the 3DG-B PM domain. However, registering >> 3DG-A with its parent fails silently, as the 3DG-B PM domain hasn't been >> registered yet, and such failures are never reported. >> >> Fix this by: >> 1. Splitting PM Domain initialization in two steps, so all PM domains >> are registered before any child-parent links are established, >> 2. Reporting any failures in establishing child-parent relations. >> >> Check for and report pm_genpd_init() failures, too, as that function >> gained a return value in commit 7eb231c337e00735 ("PM / Domains: Convert >> pm_genpd_init() to return an error code"). >> >> Fixes: 086b399965a7ee7e ("soc: renesas: r8a77990-sysc: Add workaround for >> 3DG-{A,B}") > > That makes this a fix for v4.18, right?
Correct. >> Signed-off-by: Geert Uytterhoeven <[email protected]> > > This looks fine to me but I will wait to see if there are other reviews > before applying. Let's wait for feedback from Shimoda-san. Perpaps the quirk did rely on the buggy behavior. > Reviewed-by: Simon Horman <[email protected]> Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
