On Wed, Jun 06, 2018 at 11:22:41AM +0200, Geert Uytterhoeven wrote: > Hi Russell, > > On Wed, Jun 6, 2018 at 11:09 AM, Russell King - ARM Linux > <[email protected]> wrote: > >> Fixes: cad160ed0a94927e ("ARM: shmobile: Convert file to use cntvoff") > >> Signed-off-by: Geert Uytterhoeven <[email protected]> > > > > This doesn't look right to me, but I don't have secure_cntvoff in any > > tree here that I can look at to check. What if secure_cntvoff contains > > instructions only available on ARMv7 CPUs, and not ARMv4? > > Compiled != called.
That makes little difference when the assembler validates that the instructions are possible on the target architecture and errors out if not. That's why I qualified my reply by saying that I didn't have the contents of secure_cntvoff to reference - there's no clue whether it's a .c or .S file from just this patch, and there's no visibility what it contains. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up
