On Mon, Jun 25, 2018 at 4:30 PM Wolfram Sang <[email protected]> wrote: > On Sat, Jun 16, 2018 at 09:56:36PM +0900, Wolfram Sang wrote: > > It seems that during the conversion from gpio* to gpiod*, the initial > > state of SCL was wrongly switched to LOW. Fix it to be HIGH again. > > > > Fixes: 7bb75029ef34 ("i2c: gpio: Enforce open drain through gpiolib") > > Signed-off-by: Wolfram Sang <[email protected]> > > --- > > > > Linus: Or was it intentional? But then I am missing something... I found > > this > > by trying to fix a regression. I can't scope my use case now because I am on > > the road. I recall SCL being unexpectedly LOW when using the GPIO fault > > injector the last time, though. This made me do a fix in the underlying > > i2c-algo-bit algorithm, but that sadly caused a regression :( So, this may > > be > > the proper fix. RFC for now, until I have my scope back. But discussion is > > welcome. > > Linus: any comment?
Looks like a mistake on my part. Mea culpa :( Luckily it is functionally mostly harmless, but to conserve power, it is better to initialize this as high (lest we dissipate power throught the pull-up resistor), so please queue this as a fix and also tag for stable. Reviewed-by: Linus Walleij <[email protected]> Yours, Linus Walleij
