Hi Phil,
On Thu, Jul 12, 2018 at 2:03 PM Phil Edworthy <[email protected]> wrote:
> On 11 July 2018 16:02, Phil Edworthy wrote:
> > On 11 July 2018 13:42, Geert Uytterhoeven wrote:
> > > On Wed, Jul 11, 2018 at 2:30 PM Phil Edworthy wrote:
> > > > The Renesas RZ/N1 UART is based on the Synopsys DW UART, but has
> > > > additional registers for DMA. This patch does not address the
> > > > changes required for DMA support, it simply adds the compatible string.
> > > >
> > > > Signed-off-by: Phil Edworthy <[email protected]>
> > >
> > > Thanks for your patch!
> > >
> [...]
> > > > --- a/drivers/tty/serial/8250/8250_dw.c
> > > > +++ b/drivers/tty/serial/8250/8250_dw.c
> > > > @@ -693,6 +693,7 @@ static const struct of_device_id
> > > > dw8250_of_match[]
> > > = {
> > > > { .compatible = "snps,dw-apb-uart" },
> > > > { .compatible = "cavium,octeon-3860-uart" },
> > > > { .compatible = "marvell,armada-38x-uart" },
> > > > + { .compatible = "renesas,uart-rzn1" },
> > >
> > > renesas,rzn1-uart
> I missed this comment. I followed the renesas convention of
> renesas,peripheral-device
> that is used for most R-Car drivers, but happy to change.
"renesas,<peripheral>-<family-or-device>" is the old scheme, which we cannot
change for existing devices due to backwards compatibility.
"renesas,<family-or-device>-<peripheral>" is the "new" scheme, consistent
with other vendors.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
