Hello! On 07/19/2018 02:51 PM, Magnus Damm wrote:
> From: Magnus Damm <[email protected]> > > According to the data sheet the Ethernet-AVB hardware in R-Car Gen3 > and R-Car Gen2 SoCs do not support half duplex operation. So update > the driver to mark 100Mbit HDX as unsupported. What about 1000Mbit HDX? > Not-Yet-Signed-off-by: Magnus Damm <[email protected]> > --- > > Written on top of renesas-drivers-2018-07-17-v4.18-rc5 > > drivers/net/ethernet/renesas/ravb_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- 0001/drivers/net/ethernet/renesas/ravb_main.c > +++ work/drivers/net/ethernet/renesas/ravb_main.c 2018-07-19 > 19:18:38.210607110 +0900 > @@ -1066,8 +1066,8 @@ static int ravb_phy_init(struct net_devi > netdev_info(ndev, "limited PHY to 100Mbit/s\n"); > } > > - /* 10BASE is not supported */ > - phydev->supported &= ~PHY_10BT_FEATURES; > + /* Nether 10BASE nor half duplex is supported */ Neither. s/is/are/? > + phydev->supported &= ~(PHY_10BT_FEATURES | SUPPORTED_100baseT_Half); I think you missed SUPPORTED_1000baseT_Half. [garbage skipped] MBR, Sergei
