Hi Wolfram,
On 2018-07-25 14:21:07 +0200, Wolfram Sang wrote:
> Hi Niklas,
>
> > * Changes since v3
> > - Add check for 4TAP for HS400.
>
> Is it the same in the BSP or where does this info come from?
It comes from the BSP but I had to modify it to fit with the upstream
implementation of 4 vs 8 taps. The original code from BSP:
if (!(host->mmc->ios.timing == MMC_TIMING_UHS_SDR104) &&
!(host->mmc->ios.timing == MMC_TIMING_MMC_HS200) &&
!(host->mmc->ios.timing == MMC_TIMING_MMC_HS400 &&
!host->hs400_use_4tap))
return false;
>
>
> > + if (!(host->mmc->ios.timing == MMC_TIMING_UHS_SDR104) &&
> > + !(host->mmc->ios.timing == MMC_TIMING_MMC_HS200) &&
> > + !(host->mmc->ios.timing == MMC_TIMING_MMC_HS400 &&
> > + !(host->pdata->flags & TMIO_MMC_HAVE_4TAP_HS400)))
>
> This becomes very hard to read. We need to simplify it.
I agree but I could not find a neat way of doing it. How about?
bool use_4tap = host->pdata->flags & TMIO_MMC_HAVE_4TAP_HS400;
if (!(host->mmc->ios.timing == MMC_TIMING_UHS_SDR104) &&
!(host->mmc->ios.timing == MMC_TIMING_MMC_HS200) &&
!(host->mmc->ios.timing == MMC_TIMING_MMC_HS400 && !use_4tap))
return false;
>
> And can you bounce me your debugging mail from today again? I seem to
> have lost it :(
Bounced.
>
> Thanks,
>
> Wolfram
--
Regards,
Niklas Söderlund
