On Wed, Jul 25, 2018 at 11:48:09AM +0100, Sudeep Holla wrote:
> Commit 7f9545aa1a91 ("arm64: smp: remove cpu and numa topology
> information when hotplugging out CPU") updates the cpu topology when
> the CPU is hotplugged out. However the PSCI checker code uses the
> topology_core_cpumask pointers for some of the cpu hotplug testing.
> Since the pointer to the core_cpumask of the first CPU in the group
> is used, which when that CPU itself is hotpugged out is just set to
> itself, the testing terminates after that particular CPU is tested out.
> But the intention of this tests is to cover all the CPU in the group.
>
> In order to support that, we need to stash the topology_core_cpumask
> before the start of the test and use that value instead of pointer to
> a cpumask which will be updated on CPU hotplug.
>
> Fixes: 7f9545aa1a91a9a4 ("arm64: smp: remove cpu and numa topology
> information when hotplugging out CPU")
> Reported-by: Geert Uytterhoeven <[email protected]>
> Tested-by: Geert Uytterhoeven <[email protected]>
> Cc: Mark Rutland <[email protected]>
> Acked-by: Lorenzo Pieralisi <[email protected]>
> Signed-off-by: Sudeep Holla <[email protected]>
> ---
> drivers/firmware/psci_checker.c | 83
> ++++++++++++++++++++++++-----------------
> 1 file changed, 49 insertions(+), 34 deletions(-)
>
> Hi ARM SoC,
>
> Though the fixes tag points to a commit in arm64/for-next/core,
> it shouldn't be any issue to take this via ARM SoC for v4.19
> Will suggested the same.
Ok, applied to our next/drivers branch now. Thanks!
-Olof
