Hi Wolfram,

On Wed, Jul 25, 2018 at 9:18 PM Wolfram Sang
<[email protected]> wrote:
> From: Takeshi Kihara <[email protected]>
>
> This patch adds SATA controller node for the R8A77965 SoC.

Thanks for your patch!

> Signed-off-by: Takeshi Kihara <[email protected]>
> [wsa: rebased to upstream base]
> Signed-off-by: Wolfram Sang <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -908,6 +908,17 @@
>                         status = "disabled";
>                 };
>
> +               sata: sata@ee300000 {

Please insert this node in between sd@ee160000 and
interrupt-controller@f1010000, to preserve sort order (by unit address per
device group first, by device index second).

> +                       compatible = "renesas,sata-r8a77965",
> +                                    "renesas,rcar-gen3-sata";
> +                       reg = <0 0xee300000 0 0x200000>;
> +                       interrupts = <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
> +                       clocks = <&cpg CPG_MOD 815>;
> +                       power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
> +                       resets = <&cpg 815>;
> +                       status = "disabled";
> +               };
> +
>                 scif0: serial@e6e60000 {
>                         compatible = "renesas,scif-r8a77965",
>                                      "renesas,rcar-gen3-scif", "renesas,scif";

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Reply via email to