Hi Geert-san, > From: Geert Uytterhoeven, Sent: Tuesday, July 31, 2018 12:34 AM > > Hi Shimoda-san, > > On Mon, Jul 30, 2018 at 1:55 PM Yoshihiro Shimoda > <yoshihiro.shimoda...@renesas.com> wrote: > > This patch adds PWM device nodes and enables PWM3 and PWM5 for > > R-Car E3 Ebisu board. > > Thanks for your patch!
Thank you for your review! > This is used for blacklight control, right? Yes. > It may be a good idea to mention that in the comments and/or patch > description. I got it. I'll revise the patch description as the following. Is it good? --- This patch adds PWM device nodes and enables PWM3 and PWM5 for R-Car E3 Ebisu board. These devices are used for backlight control. --- Best regards, Yoshihiro Shimoda > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- > ge...@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds