From: Masaharu Hayakawa <masaharu.hayakawa...@renesas.com>

According to documentation, setting of PHY registers is unnecessary with
R-Car Gen3. The registers are not even described. So, don't initialize
them.

Signed-off-by: Masaharu Hayakawa <masaharu.hayakawa...@renesas.com>
[wsa: updated commit message]
Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com>
---

Tested with a Renesas R-Car M3N Salvator-XS board. I did a platform suspend to
check if the controller and PHY work properly after resume.

 drivers/ata/sata_rcar.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c
index 1ad168f76ef3..10ecb232245d 100644
--- a/drivers/ata/sata_rcar.c
+++ b/drivers/ata/sata_rcar.c
@@ -830,10 +830,11 @@ static void sata_rcar_init_controller(struct ata_host 
*host)
                sata_rcar_gen1_phy_init(priv);
                break;
        case RCAR_GEN2_SATA:
-       case RCAR_GEN3_SATA:
        case RCAR_R8A7790_ES1_SATA:
                sata_rcar_gen2_phy_init(priv);
                break;
+       case RCAR_GEN3_SATA:
+               break;
        default:
                dev_warn(host->dev, "SATA phy is not initialized\n");
                break;
@@ -995,7 +996,6 @@ static int sata_rcar_resume(struct device *dev)
                return ret;
 
        if (priv->type == RCAR_GEN3_SATA) {
-               sata_rcar_gen2_phy_init(priv);
                sata_rcar_init_module(priv);
        } else {
                /* ack and mask */
-- 
2.11.0

Reply via email to