Hi Sergei, On Mon, Aug 06, 2018 at 06:21:09PM +0300, Sergei Shtylyov wrote: > Hello! > > On 08/05/2018 02:11 AM, Eugeniu Rosca wrote: > > > After adding CAN support to arch/arm64/boot/dts/renesas/r8a77965.dtsi, > > checkpatch complained that the new compatible string > > "renesas,can-r8a77965" is not documented. Fix the warning. > > > > Signed-off-by: Eugeniu Rosca <[email protected]> > > --- > > Documentation/devicetree/bindings/net/can/rcar_can.txt | 10 +++++++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt > > b/Documentation/devicetree/bindings/net/can/rcar_can.txt > > index 94a7f33ac5e9..23264451a5a4 100644 > > --- a/Documentation/devicetree/bindings/net/can/rcar_can.txt > > +++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt > [...] > > @@ -28,9 +29,8 @@ Required properties: > > - pinctrl-0: pin control group to be used for this controller. > > - pinctrl-names: must be "default". > > > > -Required properties for "renesas,can-r8a7795" and "renesas,can-r8a7796" > > -compatible: > > -In R8A7795 and R8A7796 SoCs, "clkp2" can be CANFD clock. This is a div6 > > clock > > +Required properties for compatibles [A], [B] and [C]: > > I'd suggest to avoid the footnotes: > > Required properties for compatibles R8A7795, R8A7796, and R8A77965:
I like this proposal, since it is the least intrusive and allows future addition of SoC models with minimum amount of lines changed. Will use it in v2. > > > +For the denoted SoCs, "clkp2" can be CANFD clock. This is a div6 clock > > and can be used by both CAN and CAN FD controller at the same time. It > > needs to > > be scaled to maximum frequency if any of these controllers use it. This is > > done > > using the below properties: > [...] > > MBR, Sergei Thanks, Eugeniu.
