On Fri, Aug 10, 2018 at 07:37:18AM +0000, Biju Das wrote: > Hi Rob, > > > Subject: Re: [PATCH v2 2/5] soc: renesas: rcar-sysc: Add r8a774a1 support > > > > Hi, this is an automated email from Rob's (experimental) review bot. I found > > a couple of common problems with your patch. Please see below. > > Do I need to send another patch? The mail says " Rob's (experimental) > review bot". Previously for RZ/G1C upstreaming I have submitted the > patches in similar fashion. Is anything changed?
Yes, indeed. At one point I was enforcing such a split but as it did not seem to be a universal practice I stopped doing so. I'd like some clear guidance from Rob if he'd like this split to occur going forwards. As for this patch, I have applied it for v4.20. > > > On Thu, 2 Aug 2018 15:53:19 +0100, Biju Das wrote: > > > Add support for RZ/G2M (R8A774A1) SoC power areas to the R-Car SYSC > > > driver. > > > > > > Signed-off-by: Biju Das <biju....@bp.renesas.com> > > > Reviewed-by: Chris Paterson <chris.paters...@renesas.com> > > > Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> > > > > The preferred subject prefix is "dt-bindings: <binding dir>: ...". > > > > DT bindings (including binding headers) should be a separate patch. See > > Documentation/devicetree/bindings/submitting-patches.txt. > > Regards, > Biju > > > > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, > Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered > No. 04586709. >