> On August 8, 2018 at 9:59 AM Wolfram Sang <[email protected]> > wrote: > > > Use BIT macro to avoid shift-31-problem, indent a little more and use > GENMASK to make it easier to add new flags. > > Signed-off-by: Wolfram Sang <[email protected]> > --- > drivers/i2c/busses/i2c-rcar.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c > index 791a4aa34fdd..a9f1880e2eae 100644 > --- a/drivers/i2c/busses/i2c-rcar.c > +++ b/drivers/i2c/busses/i2c-rcar.c > @@ -19,6 +19,7 @@ > * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > * GNU General Public License for more details. > */ > +#include <linux/bitops.h> > #include <linux/clk.h> > #include <linux/delay.h> > #include <linux/dmaengine.h> > @@ -112,9 +113,9 @@ > #define ID_ARBLOST (1 << 3) > #define ID_NACK (1 << 4) > /* persistent flags */ > -#define ID_P_NO_RXDMA (1 << 30) /* HW forbids RXDMA sometimes */ > -#define ID_P_PM_BLOCKED (1 << 31) > -#define ID_P_MASK (ID_P_PM_BLOCKED | ID_P_NO_RXDMA) > +#define ID_P_NO_RXDMA BIT(30) /* HW forbids RXDMA sometimes */ > +#define ID_P_PM_BLOCKED BIT(31) > +#define ID_P_MASK GENMASK(31, 30) > > enum rcar_i2c_type { > I2C_RCAR_GEN1, > -- > 2.11.0 >
Reviewed-by: Ulrich Hecht <[email protected]> CU Uli
