On Tue, Aug 28, 2018 at 10:07:40PM +0200, Wolfram Sang wrote: > Hi Guenter, > > > > + __driver.remove = NULL; \ > > > > Does that really do any good ? If I understand correctly, the only > > impact is that the platform driver remove function will believe that > > nothing needs to be done on removal. See platform_drv_remove(). > > This might be biased for my use case. Not calling remove will also leave > the clock for that module enabled. But true, the platform device will be > removed and without proper cleanup, there could be dangling pointers. >
For many drivers the watchdog device would not be removed. That would indeed be fatal. > In general, what do you think of this approach if we'd left out the > above line? > LGTM without that line. Thanks, Guenter
