Hello! On 09/06/2018 11:27 AM, Biju Das wrote:
>> -----Original Message----- >> From: [email protected] <devicetree- >> [email protected]> On Behalf Of Sergei Shtylyov >> Sent: 05 September 2018 21:32 >> To: Daniel Lezcano <[email protected]>; Thomas Gleixner >> <[email protected]>; Rob Herring <[email protected]>; >> [email protected] >> Cc: [email protected]; [email protected] >> Subject: [PATCH 2/2] clocksource: sh_cmt: add R-Car gen3 support >> >> Add support for the R-Car gen3 CMT0 and CMT1 bindings -- they seem to be >> the same CMT0 and CMT1 as in R-Car gen2 SoCs. Also document R8A779{7|8} >> bindings as these are the R-Car gen3 SoCs for which the initial support was >> done. >> >> Signed-off-by: Sergei Shtylyov <[email protected]> >> >> --- >> Documentation/devicetree/bindings/timer/renesas,cmt.txt | 7 +++++++ >> drivers/clocksource/sh_cmt.c | 8 ++++++++ >> 2 files changed, 15 insertions(+) >> >> Index: renesas/Documentation/devicetree/bindings/timer/renesas,cmt.txt >> ========================================================== >> ========= >> --- renesas.orig/Documentation/devicetree/bindings/timer/renesas,cmt.txt >> +++ renesas/Documentation/devicetree/bindings/timer/renesas,cmt.txt >> @@ -34,6 +34,10 @@ Required Properties: >> - "renesas,r8a7793-cmt1" for the 48-bit CMT1 device included in r8a7793. >> - "renesas,r8a7794-cmt0" for the 32-bit CMT0 device included in r8a7794. >> - "renesas,r8a7794-cmt1" for the 48-bit CMT1 device included in r8a7794. >> + - "renesas,r8a77970-cmt0" for the 32-bit CMT0 device included in >> r8a77970. >> + - "renesas,r8a77970-cmt1" for the 48-bit CMT1 device included in >> r8a77970. >> + - "renesas,r8a77980-cmt0" for the 32-bit CMT0 device included in >> r8a77980. >> + - "renesas,r8a77980-cmt1" for the 48-bit CMT1 device included in >> r8a77980. >> >> - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car >> Gen2 >> and RZ/G1. >> @@ -41,6 +45,9 @@ Required Properties: >> and RZ/G1. >> These are fallbacks for r8a73a4, R-Car Gen2 and RZ/G1 >> entries >> listed above. >> + - "renesas,rcar-gen3-cmt0" for 32-bit CMT0 devices included in R-Car >> Gen3. >> + - "renesas,rcar-gen3-cmt1" for 48-bit CMT1 devices included in R-Car > > Do we need to mention CMT1/2/3 instead of CMT1, since CMT2/3 is similar to > CMT1? Well, the manual only describes CMT0 and CMT1 separately. Perhaps it would have been clearer to call them CMTT0 and CMTT1 as they stand for Compare Match Timer Type 0/1? Note at this point we already have a history of describing CMT0/1 only in the bindings as well... [...] MBR, Sergei
