On Fri, Sep 21, 2018 at 12:55:09PM +0100, Fabrizio Castro wrote: > Add SH_PFC_PIN_CFG_IO_VOLTAGE definition for the SDHI2 pins > capable of switching voltage. Please note that with the > RZ/G1C only 1 bit of the POC Control Register is used to > control each interface. > > Signed-off-by: Fabrizio Castro <fabrizio.cas...@bp.renesas.com> > Reviewed-by: Biju Das <biju....@bp.renesas.com>
In general: Acked-by: Wolfram Sang <wsa+rene...@sang-engineering.com> > + if (_bank == 4 && _pin >= 14 && _pin <= 19) > + return 1; > + > + return -EINVAL; I'd like a tad better to bail out on the error case and have the main path returning on the good case, but no strong opinion...
signature.asc
Description: PGP signature
