Hi Geert
On Wednesday, September 26, 2018, Geert Uytterhoeven wrote:
> Thanks for the update!
> Works fine on R-Car Gen2 and Gen3.
Thank you for checking!
> > struct clk **clks;
>
> In v1, you initialized clks to NULL, which was needed ...
~~~
> > + priv->base = of_iomap(np, 0);
> > + if (!priv->base) {
> > + error = -ENOMEM;
> > + goto out_err;
>
> ... because else it's still uninitialized here ...
~~~
> > +out_err:
> > + kfree(clks);
>
> ... and freed here.
Damn! I could not remember why I set it to NULL. And I moved so much
code around I thought it was a mistake, so I took it out.
> Reviewed-by: Geert Uytterhoeven <[email protected]>
> i.e. will queue in clk-renesas-for-v4.20, with the above fixed.
OK, I'll send a new version out shortly.
Chris
