On Fri, Oct 05, 2018 at 10:25:47PM +0300, Sergei Shtylyov wrote:
> Describe THS/CIVM in the R8A77970 device trees.
> 
> Based on the original (and large) patches by Vladimir Barinov.
> 
> Signed-off-by: Vladimir Barinov <[email protected]>
> Signed-off-by: Sergei Shtylyov <[email protected]>
> 
> ---
> This patch is against the 'renesas-devel-20181004-v4.19-rc6' tag of Simon
> Horman's 'renesas.git' repo.
> 
> The thermal driver/bindings patches have been posted yesterday...
> 
>  arch/arm64/boot/dts/renesas/r8a77970.dtsi |   32 
> ++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> Index: renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> ===================================================================
> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> @@ -300,6 +300,19 @@
>                       #power-domain-cells = <1>;
>               };
>  
> +             thermal: thermal@e6190000 {
> +                     compatible = "renesas,thermal-r8a77970";
> +                     reg =  <0 0xe6190000 0 0x14

What is the motivation for 0x14, to me 0x10 seems like a more natural size
for the register window.

Otherwise the patch looks good to me.

> +                             0 0xe6190100 0 0x38>;
> +                     interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>,
> +                                  <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>,
> +                                  <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
> +                     clocks = <&cpg CPG_MOD 522>;
> +                     power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
> +                     resets = <&cpg 522>;
> +                     #thermal-sensor-cells = <0>;
> +             };
> +
>               intc_ex: interrupt-controller@e61c0000 {
>                       compatible = "renesas,intc-ex-r8a77970", "renesas,irqc";
>                       #interrupt-cells = <2>;
> @@ -1033,6 +1046,25 @@
>               };
>       };
>  
> +     thermal-zones {
> +             cpu-thermal {
> +                     polling-delay-passive = <250>;
> +                     polling-delay = <1000>;
> +                     thermal-sensors = <&thermal>;
> +
> +                     trips {
> +                             cpu-crit {
> +                                     temperature = <120000>;
> +                                     hysteresis = <2000>;
> +                                     type = "critical";
> +                             };
> +                     };
> +
> +                     cooling-maps {
> +                     };
> +             };
> +     };
> +
>       timer {
>               compatible = "arm,armv8-timer";
>               interrupts-extended = <&gic GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) 
> | IRQ_TYPE_LEVEL_LOW)>,
> 

Reply via email to