There are cases when the bootloader configures a pin to work
as a function rather than GPIO, and other cases when the pin
is configured as a function at POR.
This commit makes sure the pin is configured as a GPIO the
moment we need it to work as an interrupt.

Signed-off-by: Fabrizio Castro <fabrizio.cas...@bp.renesas.com>
---
RFC->PATCH:
* Moved gc->request to the bottom of gpio_rcar_irq_set_type

 drivers/gpio/gpio-rcar.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
index 3c82bb3..5b96ee3 100644
--- a/drivers/gpio/gpio-rcar.c
+++ b/drivers/gpio/gpio-rcar.c
@@ -147,6 +147,7 @@ static int gpio_rcar_irq_set_type(struct irq_data *d, 
unsigned int type)
        struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
        struct gpio_rcar_priv *p = gpiochip_get_data(gc);
        unsigned int hwirq = irqd_to_hwirq(d);
+       int err;
 
        dev_dbg(&p->pdev->dev, "sense irq = %d, type = %d\n", hwirq, type);
 
@@ -176,6 +177,13 @@ static int gpio_rcar_irq_set_type(struct irq_data *d, 
unsigned int type)
        default:
                return -EINVAL;
        }
+
+       err = gc->request(gc, hwirq);
+       if (err) {
+               dev_err(&p->pdev->dev, "Can't request GPIO %d from %s\n", hwirq,
+                       gc->label);
+               return err;
+       }
        return 0;
 }
 
-- 
2.7.4

Reply via email to