On Tue, Nov 06, 2018 at 11:18:14AM +0100, Geert Uytterhoeven wrote: > Hi Biju, > > On Fri, Oct 26, 2018 at 11:40 AM Biju Das <[email protected]> wrote: > > This patch adds watchdog support to the r8a77470 SoC dtsi. > > > > Signed-off-by: Biju Das <[email protected]> > > Thanks for your patch! > > > --- a/arch/arm/boot/dts/r8a77470.dtsi > > +++ b/arch/arm/boot/dts/r8a77470.dtsi > > @@ -196,6 +196,16 @@ > > reg = <0 0xe6160000 0 0x100>; > > }; > > > > + rwdt: watchdog@e6020000 { > > Please follow the sort order rules: > - By unit-address (if present), per group, > - Alphabetically.
Thanks for noticing. As I had already applied this patch I took the liberty of updating it to preserve node sort order. The updates patch is as follows: From: Biju Das <[email protected]> Date: Fri, 26 Oct 2018 10:32:26 +0100 Subject: [PATCH] ARM: dts: r8a77470: Add watchdog support to SoC dtsi This patch adds watchdog support to the r8a77470 SoC dtsi. Signed-off-by: Biju Das <[email protected]> Reviewed-by: Fabrizio Castro <[email protected]> [simon: moved node to preserve sort order] Signed-off-by: Simon Horman <[email protected]> --- arch/arm/boot/dts/r8a77470.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi index 6ac7f467065e..a703b74cc1f9 100644 --- a/arch/arm/boot/dts/r8a77470.dtsi +++ b/arch/arm/boot/dts/r8a77470.dtsi @@ -79,6 +79,16 @@ #size-cells = <2>; ranges; + rwdt: watchdog@e6020000 { + compatible = "renesas,r8a77470-wdt", + "renesas,rcar-gen2-wdt"; + reg = <0 0xe6020000 0 0x0c>; + clocks = <&cpg CPG_MOD 402>; + power-domains = <&sysc R8A77470_PD_ALWAYS_ON>; + resets = <&cpg 402>; + status = "disabled"; + }; + gpio0: gpio@e6050000 { compatible = "renesas,gpio-r8a77470", "renesas,rcar-gen2-gpio"; -- 2.11.0
