Hi Jacopo, Thanks for your patch!
On Tue, Nov 6, 2018 at 11:35 AM Jacopo Mondi <[email protected]> wrote: > VIN data groups may appear on different sets of pins, usually named > "vinX_data_[a|b]". The existing VIN_DATA_PIN_GROUP() does not support > appending the '_a' or '_b' suffix, leading to the definition of groups group > names not consistent with the ones defined using SH_PFC_PIN_GROUP() macro. the SH_PFC_PIN_GROUP() macro. > > Fix this by adding making the VIN_DATA_PIN_GROUP macro a variadic one, Please drop "adding". VIN_DATA_PIN_GROUP() > which accepts an optional 'version' argument. > > Signed-off-by: Jacopo Mondi <[email protected]> Reviewed-by: Geert Uytterhoeven <[email protected]> > --- a/drivers/pinctrl/sh-pfc/sh_pfc.h > +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h > @@ -54,15 +54,16 @@ struct sh_pfc_pin_group { > > /* > * Using union vin_data saves memory occupied by the VIN data pins. > - * VIN_DATA_PIN_GROUP() is a macro used to describe the VIN pin groups > - * in this case. > + * VIN_DATA_PIN_GROUP() is a macro used to describe the VIN pin groups > + * in this case. It accepts an optional 'version' argument used when the > + * same group can appear on a different set of pins. Please rebase against sh-pfc-for-v4.21. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
