> Please run scripts/get_maintainer.pl on your patches, to get the list of > maintainers. > > CC thermal
Thanks, Geert!
Hi Hoan,
> + /* Enable hwmon thermal sysfs */
> + tsc->zone->tzp->no_hwmon = false;
A driver diving so deep into core structures always looks suspicious.
Questions I have:
1)
We have that code also in rcar_thermal.c, but the commit introducing
it[1] has a reason which does not apply for this driver, or?
2)
of_parse_thermal_zones() intentionally sets this flag with this
comment:
/* No hwmon because there might be hwmon drivers registering */
Why does it not apply for us?
3)
If it turns out, we really need it, there should be some thermal core
helper or flag for it, I'd think...
Regards,
Wolfram
[1] 64a411e8042e ("thermal: rcar-thermal: enable hwmon when
thermal_zone_of_sensor_register is used")
signature.asc
Description: PGP signature
