On Fri, Nov 23, 2018 at 10:21:39AM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Wed, Nov 21, 2018 at 1:12 PM Simon Horman <[email protected]> > wrote: > > > > From: Takeshi Kihara <[email protected]> > > > > This patch adds I2C-DVFS device node for the R8A77990 SoC. > > > > v2 > > * Drop aliases update as in upstream it is not required to configure the > > BD9571 PMIC for DDR backup, nor is the use of i2c are aliases desired. > > * Do not describe the device as compatible with "renesas,rcar-gen3-iic" or > > "renesas,rmobile-iic" fallback compat strings. The absence of automatic > > transmission registers leads us to declare the r8a77990 IIC controller as > > incompatible. > > > > Signed-off-by: Takeshi Kihara <[email protected]> > > Signed-off-by: Yoshihiro Kaneko <[email protected]> > > [simon: drop aliases hunk and fallback compat string usage] > > Signed-off-by: Simon Horman <[email protected]> > > Thanks for the update! > > > --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi > > @@ -357,6 +357,20 @@ > > reg = <0 0xe6060000 0 0x508>; > > }; > > > > + i2c_dvfs: i2c@e60b0000 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + compatible = "renesas,iic-r8a77990"; > > + reg = <0 0xe60b0000 0 0x34>; > > ... 0x15>;
Thanks, sorry for missing that. > > + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&cpg CPG_MOD 926>; > > + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; > > + resets = <&cpg 926>; > > + dmas = <&dmac0 0x11>, <&dmac0 0x10>; > > + dma-names = "tx", "rx"; > > + status = "disabled"; > > + }; > > With thwe above fixed: > Reviewed-by: Geert Uytterhoeven <[email protected]> I have applied the following for v4.21: >From 0b80b6f4b26e3c6e5861234badc4b12ef2928cac Mon Sep 17 00:00:00 2001 From: Takeshi Kihara <[email protected]> Date: Wed, 21 Nov 2018 13:11:39 +0100 Subject: [PATCH] arm64: dts: renesas: r8a77990: Add I2C-DVFS device node This patch adds I2C-DVFS device node for the R8A77990 SoC. v2 * Drop aliases update as in upstream it is not required to configure the BD9571 PMIC for DDR backup, nor is the use of i2c are aliases desired. * Do not describe the device as compatible with "renesas,rcar-gen3-iic" or "renesas,rmobile-iic" fallback compat strings. The absence of automatic transmission registers leads us to declare the r8a77990 IIC controller as incompatible. v2.1 * Reduced register range to reflect documentation Signed-off-by: Takeshi Kihara <[email protected]> Signed-off-by: Yoshihiro Kaneko <[email protected]> Signed-off-by: Simon Horman <[email protected]> Reviewed-by: Geert Uytterhoeven <[email protected]> Signed-off-by: Simon Horman <[email protected]> --- arch/arm64/boot/dts/renesas/r8a77990.dtsi | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi index b0398e05e8ed..3b334be843f4 100644 --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi @@ -357,6 +357,20 @@ reg = <0 0xe6060000 0 0x508>; }; + i2c_dvfs: i2c@e60b0000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a77990"; + reg = <0 0xe60b0000 0 0x15>; + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 926>; + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; + resets = <&cpg 926>; + dmas = <&dmac0 0x11>, <&dmac0 0x10>; + dma-names = "tx", "rx"; + status = "disabled"; + }; + cpg: clock-controller@e6150000 { compatible = "renesas,r8a77990-cpg-mssr"; reg = <0 0xe6150000 0 0x1000>; -- 2.11.0
