Hi Wolfram, On Mon, Dec 3, 2018 at 3:27 PM Wolfram Sang <[email protected]> wrote: > If we use it this way, people should know about it. > > Signed-off-by: Wolfram Sang <[email protected]>
Reviewed-by: Geert Uytterhoeven <[email protected]> > --- > > Still not super happy about shifting into the sign bit, but yeah... > don't break userspace, I guess. Indeed. > include/uapi/linux/mmc/ioctl.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/linux/mmc/ioctl.h b/include/uapi/linux/mmc/ioctl.h > index 45f369dc0a42..ae659333e73f 100644 > --- a/include/uapi/linux/mmc/ioctl.h > +++ b/include/uapi/linux/mmc/ioctl.h > @@ -5,7 +5,10 @@ > #include <linux/types.h> > > struct mmc_ioc_cmd { > - /* Implies direction of data. true = write, false = read */ > + /* > + * Implies direction of data. true = write, false = read. nonzero = write, zero = read? > + * Bit 31 selects 'Reliable Write' for RPMB. Perhaps having a #define for this would be nice? Can also be used by the driver, instead of 1 << 31, which some static analyzers may complain about. > + */ > int write_flag; > > /* Application-specific command. true = precede with CMD55 */ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
