On Tue, Oct 09, 2018 at 11:28:40AM +0200, Geert Uytterhoeven wrote: > Hi Sergei, > > On Tue, Sep 18, 2018 at 6:55 PM Sergei Shtylyov > <[email protected]> wrote: > > On 09/18/2018 01:22 PM, Simon Horman wrote: > > > From: Kazuya Mizuguchi <[email protected]> > > > EtherAVB hardware requires 0 to be written to status register bits in > > > order to clear them, however, care must be taken not to: > > > > > > 1. Clear other bits, by writing zero to them > > > 2. Write one to reserved bits > > > > > > This patch corrects the ravb driver with respect to the second point > > > above. > > > This is done by defining reserved bit masks for the affected registers > > > and, > > > after auditing the code, ensure all sites that may write a one to a > > > reserved bit use are suitably masked. > > > > > > Signed-off-by: Kazuya Mizuguchi <[email protected]> > > > Signed-off-by: Simon Horman <[email protected]> > > [...] > > > > Reviewed-by: Sergei Shtylyov <[email protected]> > > > > > diff --git a/drivers/net/ethernet/renesas/ravb.h > > > b/drivers/net/ethernet/renesas/ravb.h > > > index 1470fc12282b..9b6bf557a2f5 100644 > > > --- a/drivers/net/ethernet/renesas/ravb.h > > > +++ b/drivers/net/ethernet/renesas/ravb.h > > > @@ -428,6 +428,7 @@ enum EIS_BIT { > > > EIS_CULF1 = 0x00000080, > > > EIS_TFFF = 0x00000100, > > > EIS_QFS = 0x00010000, > > > + EIS_RESERVED = (GENMASK(31, 17) | GENMASK(15, 11)), > > > > Well, I'm not a big fan of BIT() and GENMASK() -- they still lack a macro > > to #define a bit/field value. But if you prefer to use them, OK, let's be > > so... > > FIELD_PREP()? > > Perhaps the other bit definitions should be converted to BIT()? > That way it becomes much easier to match valid EIS_* bits with EIS_RESERVED.
+1
