Hi Geert, On Mon, Nov 05, 2018 at 06:19:22PM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Mon, Oct 29, 2018 at 7:14 PM Jacopo Mondi <[email protected]> > wrote: > > this two patches add supports for VIN4 and VIN5 interfaces to R-Car M3-N. > > > > On this SoC (and in the forthcoming support for E3 R8A77990) the VIN groups > > could appear on different sets of pins, usually the 'a' and 'b' one. > > > > With the existing VIN_DATA_PIN_GROUP macro we have to specify group names > > as: > > > > VIN_DATA_PIN_GROUP(vin4_data_a, 8) > > > > which results in the group being named as "vin4_data_a_8" which is > > un-consistent with the canonical group names (eg. "vin4_data8_a"). > > > > This series adds a macro that allows to specify the group 'version' along > > with > > the pin and mux numbers in patch [1/1]. I haven't been able to find a better > > term than 'version' as 'group' was already taken. Suggestions welcome. > > Yeah, the datasheet also calls these groups :-( > A possible alternative is to use "variant"? > > Or, what about avoiding the name issue by making the VIN_DATA_PIN_GROUP() > macro varargs, and passing the "variant" as the (optional) third parameter? > That way existing users work as a before, while you can also write e.g. > > VIN_DATA_PIN_GROUP_VER(vin4_data, 8, _a),
Indeed.
Would something along the following lines fly for you?
#define VIN_DATA_PIN_GROUP(n, s, ...) \
{ \
.name = #n#s#__VA_ARGS__, \
.pins = n##__VA_ARGS__##_pins.data##s, \
.mux = n##__VA_ARGS__##_mux.data##s, \
.nr_pins = ARRAY_SIZE(n##__VA_ARGS__##_pins.data##s), \
}
It can be used as:
VIN_DATA_PIN_GROUP(vin4_data, 8, _a),
VIN_DATA_PIN_GROUP(vin5_data, 8),
With your ack on this, I'll send v2.
Thanks
j
>
> > As I cannot test VIN4 nor VIN5 on Salvator-XS as the parallel pins are not
> > wired, I made sure the macro creates correct names and fields not only by
> > compile testing it, but with a small C program [1] that replicates the VIN
> > data
> > layout defined in the PFC module and access fields (and has helped me
> > testing
> > more easily the preprocessor stringification/concatenation process).
> >
> > Final note: Simon, you took the E3 patches in your tree, and I expect them
> > to
> > land on v4.20-rc1. They use the old macros, are follow up patches ok?)
>
> Which patches are using these macro names, and are in v4.20-rc1?
>
> BTW, "grep vin._data_[a-z][0-9] drivers/pinctrl/sh-pfc/*o" tells me we already
> have broken groups names on r8a7792, r8a7795, and r8a7796.
> Fortunately we have no known users of them, so they can be fixed.
>
On v4.20-rc1 the grep returns none for me :/
git grep v4.20-rc1 "vin._data_[a-z][0-9]" drivers/pinctrl/sh-pfc/
Thanks
j
> Thanks!
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
signature.asc
Description: PGP signature
