Re: [PATCH v3 3/4] serial: sh-sci: Resume PIO in sci_rx_interrupt() on DMA failure

[Wolfram Sang]

Hi Geert,

>       if (!port_lock_held)
>               spin_unlock_irqrestore(&port->lock, flags);
> +     return -1;

-Esomething here...

>               } else {
> +                     if (sci_submit_rx(s, false))
> +                             goto handle_pio;

and 'sci_submit_rx() < 0' here? I think it makes it more readable that
this is an error case then. 'if sci_submit_rx() do_something' sounds a
bit like the good case if boolean logic was used.

Thanks for picking this up again,

   Wolfram

signature.asc
Description: PGP signature