Re: [PATCH] arm64: dts: renesas: r8a77990: ebisu: Add backlight

[Simon Horman]

On Sun, Dec 16, 2018 at 01:47:44PM +0200, Laurent Pinchart wrote:
> Add the backlight device for the LVDS1 output, in preparation for panel
> support.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>

I would value a review of this patch.

> ---
>  .../arm64/boot/dts/renesas/r8a77990-ebisu.dts | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts 
> b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> index 528e805a9d52..b8ba790907af 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> @@ -29,6 +29,16 @@
>               reg = <0x0 0x48000000 0x0 0x38000000>;
>       };
>  
> +     backlight: backlight {
> +             compatible = "pwm-backlight";
> +             pwms = <&pwm3 0 50000>;
> +
> +             brightness-levels = <512 511 505 494 473 440 392 327 241 133 0>;
> +             default-brightness-level = <10>;
> +
> +             power-supply = <&reg_12p0v>;
> +     };
> +
>       cvbs-in {
>               compatible = "composite-video-connector";
>               label = "CVBS IN";
> @@ -128,6 +138,15 @@
>               regulator-always-on;
>       };
>  
> +     reg_12p0v: regulator1 {
> +             compatible = "regulator-fixed";
> +             regulator-name = "D12.0V";
> +             regulator-min-microvolt = <12000000>;
> +             regulator-max-microvolt = <12000000>;
> +             regulator-boot-on;
> +             regulator-always-on;
> +     };
> +
>       x13_clk: x13 {
>               compatible = "fixed-clock";
>               #clock-cells = <0>;
> -- 
> Regards,
> 
> Laurent Pinchart
>