Re: [PATCH 2/8] arm64: renesas: ulcb: add HDMI sound support

[Simon Horman]

On Wed, Dec 26, 2018 at 09:53:34AM +0900, Kuninori Morimoto wrote:
> 
> From: Kuninori Morimoto <kuninori.morimoto...@renesas.com>
> 
> This patch adds missing ULCB HDMI sound support.
> To use sound card, HDMI video is mandatory.

Hi Morimoto-san,

I realise that I previously indicated that I was happy with this series,
but I have found a, hopefully, minor problem.

When compiling this patch I see:

# make W=1 dtbs
...

  DTC     arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dtb
arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dtb: Warning (unit_address_vs_reg): 
/soc/sound@ec500000/ports/port@0: node has a unit name, but no reg property
arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dtb: Warning (unit_address_vs_reg): 
/soc/sound@ec500000/ports/port@1: node has a unit name, but no reg property
  DTC     arch/arm64/boot/dts/renesas/r8a7795-h3ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a7795-h3ulcb-kf.dtb: Warning 
(unit_address_vs_reg): /soc/sound@ec500000/ports/port@0: node has a unit name, 
but no reg property
arch/arm64/boot/dts/renesas/r8a7795-h3ulcb-kf.dtb: Warning 
(unit_address_vs_reg): /soc/sound@ec500000/ports/port@1: node has a unit name, 
but no reg property
  DTC     arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb.dtb
arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb.dtb: Warning 
(unit_address_vs_reg): /soc/sound@ec500000/ports/port@0: node has a unit name, 
but no reg property
arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb.dtb: Warning 
(unit_address_vs_reg): /soc/sound@ec500000/ports/port@1: node has a unit name, 
but no reg property
  DTC     arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb-kf.dtb: Warning 
(unit_address_vs_reg): /soc/sound@ec500000/ports/port@0: node has a unit name, 
but no reg property
arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb-kf.dtb: Warning 
(unit_address_vs_reg): /soc/sound@ec500000/ports/port@1: node has a unit name, 
but no reg property
  DTC     arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dtb
  DTC     arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dtb
  DTC     arch/arm64/boot/dts/renesas/r8a77965-m3nulcb.dtb
arch/arm64/boot/dts/renesas/r8a77965-m3nulcb.dtb: Warning 
(unit_address_vs_reg): /soc/sound@ec500000/ports/port@0: node has a unit name, 
but no reg property
arch/arm64/boot/dts/renesas/r8a77965-m3nulcb.dtb: Warning 
(unit_address_vs_reg): /soc/sound@ec500000/ports/port@1: node has a unit name, 
but no reg property
  DTC     arch/arm64/boot/dts/renesas/r8a77965-m3nulcb-kf.dtb
arch/arm64/boot/dts/renesas/r8a77965-m3nulcb-kf.dtb: Warning 
(unit_address_vs_reg): /soc/sound@ec500000/ports/port@0: node has a unit name, 
but no reg property
arch/arm64/boot/dts/renesas/r8a77965-m3nulcb-kf.dtb: Warning 
(unit_address_vs_reg): /soc/sound@ec500000/ports/port@1: node has a unit name, 
but no reg property


Locally the following incremental change seems to help.
Could you consider rolling this or a different solution into a v2
of this patchset?


diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi 
b/arch/arm64/boot/dts/renesas/ulcb.dtsi
index 76e128a01b61..065342f6d0dd 100644
--- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
@@ -398,7 +398,12 @@
                 <&cpg CPG_CORE CPG_AUDIO_CLK_I>;
 
        ports {
+               #address-cells = <1>;
+               #size-cells = <0>;
+
                rsnd_port0: port@0 {
+                       reg = <0>;
+
                        rsnd_for_ak4613: endpoint {
                                remote-endpoint = <&ak4613_endpoint>;
 
@@ -411,6 +416,8 @@
                        };
                };
                rsnd_port1: port@1 {
+                       reg = <1>;
+
                        rsnd_for_hdmi: endpoint {
                                remote-endpoint = <&dw_hdmi0_snd_in>;