On Wed, Jan 09, 2019 at 04:26:25PM +0100, Geert Uytterhoeven wrote: > On Wed, Jan 9, 2019 at 3:01 PM <[email protected]> wrote: > > From: Marek Vasut <[email protected]> > > > > There are two regulator1 nodes in the Ebisu DTS right now, one 3.3V for > > the eMMC and one 12V for the backlight. This causes one to be overwritten > > by the other, ultimatelly resulting in inoperable eMMC, which depends on > > the former. Fix this by renumbering the backlight regulator to regulator2. > > > > Signed-off-by: Marek Vasut <[email protected]> > > Cc: Laurent Pinchart <[email protected]> > > Cc: Simon Horman <[email protected]> > > Cc: Wolfram Sang <[email protected]> > > Cc: [email protected] > > Reported-by: Simon Horman <[email protected]> > > Fixes: 9d16c4a10e07 ("arm64: dts: renesas: r8a77990: ebisu: Add backlight") > > Reviewed-by: Geert Uytterhoeven <[email protected]> > > > --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > > +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > > @@ -191,7 +191,7 @@ > > clock-frequency = <24576000>; > > }; > > > > - reg_12p0v: regulator1 { > > + reg_12p0v: regulator2 { > > compatible = "regulator-fixed"; > > regulator-name = "D12.0V"; > > regulator-min-microvolt = <12000000>; > > Perhaps the node name should get a more descriptive suffix > (e.g. "regulator-12p0v"), like is already done for some of the other > regulators?
I think I would prefer that addressed in a follow-up patch.
