Hi Niklas, Takeshi,

On 16/02/2019 23:58, Niklas Söderlund wrote:
> From: Takeshi Kihara <takeshi.kihara...@renesas.com>
> 
> The register address used for the reg property of the adv7482 node in
> other Renesas device trees are decimal not hex, change this for Ebisu to
> align it with the others.
> 
> Signed-off-by: Takeshi Kihara <takeshi.kihara...@renesas.com>
> [Niklas: rewrite commit message]
> Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se>
> ---
>  arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts 
> b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> index 62bdddcbbae7d9e9..23914c2b83965621 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> @@ -383,7 +383,7 @@
>               };
>  
>               port@a {
> -                     reg = <0xa>;
> +                     reg = <10>;

>From the discussions on this before, we converted the port number to be hex.

I really dislike that we have port@a, but reg=<10>;

However as long as the value is written by the DTC as 'ten' and
correctly interpreted as decimal this is still correct.

I guess it doesn't hurt to have a decimal representation as that will
then match the bindings port descriptions. It's a shame this can't be
the 'port@10' for comprehension though.

My only hesitation on providing either an RB/or AB tag here is whether
perhaps we should instead convert the salvator-common to use hex so that
they match that way instead?

--
Regards

Kieran

>  
>                       adv7482_txa: endpoint {
>                               clock-lanes = <0>;
> 


-- 
Regards
--
Kieran

Reply via email to