On 3/18/19 9:47 AM, Geert Uytterhoeven wrote: > Hi Marek, > > On Sun, Mar 17, 2019 at 1:06 AM <[email protected]> wrote: >> From: Marek Vasut <[email protected]> >> >> Replace unsigned long with u32 type for variables holding >> register values, since the registers are 32bit. Note that >> rcar_pcie_msi_irq() still uses unsigned long because both >> find_first_bit() and __fls() require unsigned long as an >> argument. >> >> Signed-off-by: Marek Vasut <[email protected]> >> Cc: Geert Uytterhoeven <[email protected]> >> Cc: Phil Edworthy <[email protected]> >> Cc: Simon Horman <[email protected]> >> Cc: Wolfram Sang <[email protected]> >> Cc: [email protected] >> To: [email protected] >> --- >> drivers/pci/controller/pcie-rcar.c | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/pci/controller/pcie-rcar.c >> b/drivers/pci/controller/pcie-rcar.c >> index 1408c8aa758b..857d88fd03d5 100644 >> --- a/drivers/pci/controller/pcie-rcar.c >> +++ b/drivers/pci/controller/pcie-rcar.c >> @@ -169,7 +169,7 @@ enum { >> >> static void rcar_rmw32(struct rcar_pcie *pcie, int where, u32 mask, u32 >> data) >> { >> - int shift = 8 * (where & 3); >> + u32 shift = 8 * (where & 3); > > shift is not a register value, so IMHO the original type is fine (the "int" > comes from the pci_ops API, BTW).
I presume it should be at least unsigned ? [...] -- Best regards, Marek Vasut
