Hi Cao,

On 2019-04-09 17:51:46 +0900, Cao Van Dong wrote:
> Add vin{0|1} nodes to dtsi for VIN support on the RZ/G1C (r8a77470) SoC.
> 
> Signed-off-by: Cao Van Dong <[email protected]>
> ---
>  arch/arm/boot/dts/r8a77470.dtsi | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi
> index 3940a0d..e89c72f 100644
> --- a/arch/arm/boot/dts/r8a77470.dtsi
> +++ b/arch/arm/boot/dts/r8a77470.dtsi
> @@ -780,6 +780,28 @@
>                       status = "disabled";
>               };
>  
> +             vin0: video@e6ef0000 {
> +                     compatible = "renesas,vin-r8a77470",
> +                                  "renesas,rcar-gen2-vin";

This patch looks good but you should also add renesas,vin-r8a77470 to 
Documentation/devicetree/bindings/media/rcar_vin.txt in a separate 
patch.

Reviewed-by: Niklas Söderlund <[email protected]>

> +                     reg = <0 0xe6ef0000 0 0x1000>;
> +                     interrupts = <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>;
> +                     clocks = <&cpg CPG_MOD 811>;
> +                     power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
> +                     resets = <&cpg 811>;
> +                     status = "disabled";
> +             };
> +
> +             vin1: video@e6ef1000 {
> +                     compatible = "renesas,vin-r8a77470",
> +                                  "renesas,rcar-gen2-vin";
> +                     reg = <0 0xe6ef1000 0 0x1000>;
> +                     interrupts = <GIC_SPI 189 IRQ_TYPE_LEVEL_HIGH>;
> +                     clocks = <&cpg CPG_MOD 810>;
> +                     power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
> +                     resets = <&cpg 810>;
> +                     status = "disabled";
> +             };
> +
>               sdhi0: sd@ee100000 {
>                       compatible = "renesas,sdhi-r8a77470",
>                                    "renesas,rcar-gen2-sdhi";
> -- 
> 2.7.4
> 

-- 
Regards,
Niklas Söderlund

Reply via email to