Hi Geert,

Thanks for the feedback.

Simon,
 
How do you want to address this? A new patch for  taking out 
"CONFIG_GENERIC_PHY=y"
from shmobile_defconfig  ?? Please let us know.

Regards,
Biju


> -----Original Message-----
> From: [email protected] <linux-renesas-soc-
> [email protected]> On Behalf Of Geert Uytterhoeven
> Sent: 23 April 2019 10:21
> To: Simon Horman <[email protected]>; Biju Das
> <[email protected]>
> Cc: Linux-Renesas <[email protected]>; Magnus Damm
> <[email protected]>; Linux ARM <linux-arm-
> [email protected]>
> Subject: Re: [PATCH 4/5] ARM: shmobile: Enable PHY_RCAR_GEN3_USB2 in
> shmobile_defconfig
> 
> Hi Simon, Biju,
> 
> On Fri, Apr 19, 2019 at 4:36 PM Simon Horman
> <[email protected]> wrote:
> > From: Biju Das <[email protected]>
> >
> > Enable PHY_RCAR_GEN3_USB2 in shmobile_defconfig so that boards
> based
> > on RZ/G1C SoC design can use the corresponding driver.
> >
> > Signed-off-by: Biju Das <[email protected]>
> > Signed-off-by: Simon Horman <[email protected]>
> > ---
> >  arch/arm/configs/shmobile_defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/configs/shmobile_defconfig
> > b/arch/arm/configs/shmobile_defconfig
> > index 291abdd650ed..30abd8176010 100644
> > --- a/arch/arm/configs/shmobile_defconfig
> > +++ b/arch/arm/configs/shmobile_defconfig
> > @@ -197,6 +197,7 @@ CONFIG_PWM_RENESAS_TPU=y
> > CONFIG_RESET_CONTROLLER=y  CONFIG_GENERIC_PHY=y
> > CONFIG_PHY_RCAR_GEN2=y
> > +CONFIG_PHY_RCAR_GEN3_USB2=y
> 
> As PHY_RCAR_GEN3_USB2 selects GENERIC_PHY, the line
> 
>     CONFIG_GENERIC_PHY=y
> 
> should be removed from shmobile_defconfig.

> >  # CONFIG_DNOTIFY is not set
> >  CONFIG_MSDOS_FS=y
> >  CONFIG_VFAT_FS=y
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like 
> that.
>                                 -- Linus Torvalds

Reply via email to