Hi Wolfram-san, > From: Wolfram Sang, Sent: Thursday, May 16, 2019 3:24 AM > > From: Takeshi Saito <[email protected]> > > If an SCC error occurs during a read/write command execution, a false > positive CRC error message is output. > > mmcblk0: response CRC error sending r/w cmd command, card status 0x900 > > check_scc_error() checks SCC_RVSREQ.RVSERR bit. RVSERR detects a > correction error in the next (up or down) delay tap position. However, > since the command is successful, only retuning needs to be executed. > This has been confirmed by HW engineers. > > Thus, on SCC error, set retuning flag instead of setting an error code. > > Fixes: b85fb0a1c8ae ("mmc: tmio: Fix SCC error detection") > Signed-off-by: Takeshi Saito <[email protected]> > [wsa: updated comment and commit message, removed some braces] > Signed-off-by: Wolfram Sang <[email protected]> > --- > > This patch was suggested by the BSP team because they were seeing CRC errors > with a hardware I don't have access to. I tested this with my R-Car H3-ES2.0 > and M3-N (both Salvator-XS), and things were still running fine. But I suggest > to wait for a final ack from Shimoda-san or someone from the BSP team.
Thank you for the patch! Reviewed-by: Yoshihiro Shimoda <[email protected]> Best regards, Yoshihiro Shimoda
