Hi Biju-san, Thank you for the patch!
> From: Biju Das, Sent: Wednesday, May 15, 2019 9:09 PM > > Update the DT bindings documentation to support usb role switch > for USB Type-C connector using USB role switch class framework. > > Signed-off-by: Biju Das <[email protected]> > --- > V5-->V6 > * Updated description > * Added usb-role-switch-property > V4-->V5 > * No Change > V3-->V4 > * No Change > V2-->V3 > * Added optional renesas,usb-role-switch property. > V1-->V2 > * Added usb-role-switch-property > * Updated the example with usb-role-switch property. > --- > .../devicetree/bindings/usb/renesas_usb3.txt | 26 > ++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > index 35039e7..ea6c63c 100644 > --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > @@ -22,6 +22,11 @@ Required properties: > Optional properties: > - phys: phandle + phy specifier pair > - phy-names: must be "usb" > + - usb-role-switch: support role switch. see usb/generic.txt > + > +Sub-nodes: > +The port would be added as a subnode if the "usb-role-switch" property is > used. > + see graph.txt I think we should describe which type of a subnode is needed. I made an example below. This is based on the usb-connector.txt. --- Sub-nodes: - any connector to the data bus of this controller should be modeled using the OF graph bindings specified in bindings/graph.txt. --- > Example of R-Car H3 ES1.x: > usb3_peri0: usb@ee020000 { > @@ -39,3 +44,24 @@ Example of R-Car H3 ES1.x: > interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&cpg CPG_MOD 327>; > }; > + > +Example of RZ/G2E: > + usb3_peri0: usb@ee020000 { > + compatible = "renesas,r8a774c0-usb3-peri", > + "renesas,rcar-gen3-usb3-peri"; > + reg = <0 0xee020000 0 0x400>; > + interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 328>; > + companion = <&xhci0>; > + usb-role-switch; > + > + port { > + #address-cells = <1>; > + #size-cells = <0>; > + > + usb3peri_role_switch: endpoint@0 { > + reg = <0>; I'm not sure, but I don't think this endpoint@0 and reg = <0> are needed. In other words, can we use have following node? usb3peri_role_switch: endpoint { remote-endpoint = <&hd3ss3220_ep>; }; Best regards, Yoshihiro Shimoda
