Hi
> This patch adds suspend/resume function support for Renesas the 16-Bit Timer
> Pulse Unit (TPU) driver. This has been tested on the Salvator-XS board
> with R-Car M3-N and H3 at renesas-drivers-2019-05-21-v5.2-rc1 tag.
> I expect this to work on other SoCs.
(snip)
> +#ifdef CONFIG_PM_SLEEP
> +static int tpu_pwm_suspend(struct device *dev)
> +{
> + struct tpu_device *tpu = dev_get_drvdata(dev);
> + struct pwm_chip *chip = &tpu->chip;
> + struct pwm_device *pwm;
> + int i;
> +
> + for (i = 0; i < TPU_CHANNEL_MAX; i++) {
> + pwm = &chip->pwms[i];
> + if (pwm_is_enabled(pwm)) {
> + if (!test_bit(PWMF_REQUESTED, &pwm->flags))
> + return 0;
> + tpu_pwm_disable(pwm->chip,pwm);
> + }
> + }
I'm not familiar with pwm driver, but pwm_is_enabled() and
if (!test_bit(PWMF_REQUESTED, &pwm->flags)) can be happen in the same time ?
In other words, can we enable pwm without PWMF_REQUESTED ?
> +static int tpu_pwm_resume(struct device *dev)
> +{
> + struct tpu_device *tpu = dev_get_drvdata(dev);
> + struct pwm_chip *chip = &tpu->chip;
> + struct pwm_device *pwm;
> + int i;
> +
> + for (i = 0; i < TPU_CHANNEL_MAX; i++) {
> + pwm = &chip->pwms[i];
> + if (pwm_is_enabled(pwm)) {
> + if (!test_bit(PWMF_REQUESTED, &pwm->flags))
> + return 0;
> + tpu_pwm_enable(pwm->chip,pwm);
> + }
> + }
Please use ${LINUX}/scripts/checkpatch.pl
Thank you for your help !!
Best regards
---
Kuninori Morimoto
