Hi Geert, Thanks for your work.
On 2019-05-27 14:35:14 +0200, Geert Uytterhoeven wrote: > pm_clk_create() and pm_clk_add_clk() can fail only when running out of > memory. Hence there is no need to print error messages on failure, as > the memory allocation core already takes care of that. > > Signed-off-by: Geert Uytterhoeven <[email protected]> Reviewed-by: Niklas Söderlund <[email protected]> > --- > To be queued in clk-renesas-for-v5.3. > > drivers/clk/renesas/clk-mstp.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/clk/renesas/clk-mstp.c b/drivers/clk/renesas/clk-mstp.c > index ebd5cd74ca0733d8..a5e9f9edf04079c7 100644 > --- a/drivers/clk/renesas/clk-mstp.c > +++ b/drivers/clk/renesas/clk-mstp.c > @@ -298,16 +298,12 @@ int cpg_mstp_attach_dev(struct generic_pm_domain > *unused, struct device *dev) > return PTR_ERR(clk); > > error = pm_clk_create(dev); > - if (error) { > - dev_err(dev, "pm_clk_create failed %d\n", error); > + if (error) > goto fail_put; > - } > > error = pm_clk_add_clk(dev, clk); > - if (error) { > - dev_err(dev, "pm_clk_add_clk %pC failed %d\n", clk, error); > + if (error) > goto fail_destroy; > - } > > return 0; > > -- > 2.17.1 > -- Regards, Niklas Söderlund
