Hi Geert-san, Thank you for your review!
> From: Geert Uytterhoeven, Sent: Friday, May 31, 2019 4:20 PM > > Hi Shimoda-san, > > On Thu, May 30, 2019 at 12:21 PM Yoshihiro Shimoda > <[email protected]> wrote: > > This patch adds power management descriptions that consumers should > > implement it. > > > > Signed-off-by: Yoshihiro Shimoda <[email protected]> > > Thanks for your patch! > > > --- a/Documentation/pwm.txt > > +++ b/Documentation/pwm.txt > > > @@ -141,6 +145,9 @@ The implementation of ->get_state() (a method used to > > retrieve initial PWM > > state) is also encouraged for the same reason: letting the PWM user know > > about the current PWM state would allow him to avoid glitches. > > > > +Drivers should not implement any power management. In other words, > > +consumers should implement it as described as the "Using PWMs" section. > > s/as/in/ So, "... in described as ..." ? I'm not a native speaker, so that any cases below seem not so different to me :) 1. "... as described as ..." 2. "... in described as ..." 3. "... as described in ..." 4. "... in described in ..." > Reviewed-by: Geert Uytterhoeven <[email protected]> Thanks! Best regards, Yoshihiro Shimoda > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- > [email protected] > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds
