Hi Shimoda-san, On Tue, Jun 04, 2019 at 01:09:34PM +0900, Yoshihiro Shimoda wrote: > SUDMAC featurer was supported in v3.10, but was never used by > any platform. So, this patch removes it. > > Signed-off-by: Yoshihiro Shimoda <[email protected]> > --- > drivers/usb/renesas_usbhs/fifo.c | 5 +---- > include/linux/usb/renesas_usbhs.h | 1 - > 2 files changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/usb/renesas_usbhs/fifo.c > b/drivers/usb/renesas_usbhs/fifo.c > index 452b456..53f8e2f 100644 > --- a/drivers/usb/renesas_usbhs/fifo.c > +++ b/drivers/usb/renesas_usbhs/fifo.c > @@ -325,10 +325,7 @@ static int usbhsf_fifo_select(struct usbhs_pipe *pipe, > } > > /* "base" will be used below */ > - if (usbhs_get_dparam(priv, has_sudmac) && !usbhsf_is_cfifo(priv, fifo))
I believe usbhsf_is_cfifo() will now be unused and should be removed. With that change feel free to add: Reviewed-by: Simon Horman <[email protected]> > - usbhs_write(priv, fifo->sel, base); > - else > - usbhs_write(priv, fifo->sel, base | MBW_32); > + usbhs_write(priv, fifo->sel, base | MBW_32); > > /* check ISEL and CURPIPE value */ > while (timeout--) { > diff --git a/include/linux/usb/renesas_usbhs.h > b/include/linux/usb/renesas_usbhs.h > index 3f53043..a2481f4d 100644 > --- a/include/linux/usb/renesas_usbhs.h > +++ b/include/linux/usb/renesas_usbhs.h > @@ -187,7 +187,6 @@ struct renesas_usbhs_driver_param { > * option: > */ > u32 has_otg:1; /* for controlling PWEN/EXTLP */ > - u32 has_sudmac:1; /* for SUDMAC */ > u32 has_usb_dmac:1; /* for USB-DMAC */ > u32 runtime_pwctrl:1; > u32 has_cnen:1; > -- > 2.7.4 >
