On Mon, Jun 17, 2019 at 10:43:09AM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Mon, Jun 17, 2019 at 10:37 AM Simon Horman > <[email protected]> wrote: > > From: Takeshi Kihara <[email protected]> > > > > It is necessary to reset the LVDS Interface according to display on/off. > > This is not the LVDS interface. > The LVDS interface has its own device node.
Thanks, how about a changelog more like this? arm64: dts: renesas: r8a77990: Add cpg reset for DU Add CPG reset properties to DU node of E3 (r8a77990) SoC. According to Laurent Pinchart, R-Car Gen3 reset is handled at the group level so specifying one reset entry per group is sufficient. For this reason <&cpg 724> is not listed as a reset for "du.1" as was the case in an earlier revision of this patch. Signed-off-by: Takeshi Kihara <[email protected]> Signed-off-by: Yoshihiro Kaneko <[email protected]> Signed-off-by: Simon Horman <[email protected]> > > Therefore, this patch adds CPG reset properties in DU device node > > for the R8A77990 SoC. > > > > According to Laurent Pinchart, R-Car Gen3 reset is handled at the group > > level so specifying one reset entry per group is sufficient. For this > > reason <&cpg 724> is not listed as a reset for "du.1" as was the case in an > > earlier revision of this patch. > > > > Signed-off-by: Takeshi Kihara <[email protected]> > > Signed-off-by: Yoshihiro Kaneko <[email protected]> > > Signed-off-by: Simon Horman <[email protected]> > > --- > > v2 [Simon Horman] > > - only add one reset entry per group > > > > v1 [Yoshihiro Kaneko] > > > > v0 [Takeshi Kihara] > > --- > > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > > b/arch/arm64/boot/dts/renesas/r8a77990.dtsi > > index b4318661f35e..84d1f58e73e7 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi > > @@ -1766,6 +1766,8 @@ > > clocks = <&cpg CPG_MOD 724>, > > <&cpg CPG_MOD 723>; > > clock-names = "du.0", "du.1"; > > + resets = <&cpg 724>; > > + reset-names = "du.0"; > > vsps = <&vspd0 0 &vspd1 0>; > > status = "disabled"; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- > [email protected] > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds >
