Hi Laurent, > From: [email protected] > <[email protected]> On Behalf Of Laurent Pinchart > Sent: 19 June 2019 13:42 > Subject: Re: [PATCH 3/3] arm64: dts: renesas: hihope-common: Add HDMI support > > Hi Fabrizio, > > Thank you for the patch. > > On Tue, Jun 18, 2019 at 04:18:39PM +0100, Fabrizio Castro wrote: > > Add HDMI support to the HiHope RZ/G2[MN] mother board common > > dtsi. > > > > Signed-off-by: Fabrizio Castro <[email protected]> > > > > --- > > Please note that this patch was tested with a 4K monitor and cma=96M > > > > arch/arm64/boot/dts/renesas/hihope-common.dtsi | 62 > > ++++++++++++++++++++++++++ > > 1 file changed, 62 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi > > b/arch/arm64/boot/dts/renesas/hihope-common.dtsi > > index 625c3aa..e7568e1 100644 > > --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi > > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi > > @@ -17,6 +17,18 @@ > > stdout-path = "serial0:115200n8"; > > }; > > > > + hdmi0-out { > > + compatible = "hdmi-connector"; > > + label = "HDMI0 OUT"; > > Is the label physically present on the device (printed on the board or > the case) ?
I am afraid it's not. Shall I send a v2? Or perhaps Simon could take it out while applying? > > Apart from that, without access to the schematics I can't really tell if > the DT is correct, but nothing strikes me as really wrong, so I didn't know you had no access to the schematics, on their way... Thanks, Fab > > Acked-by: Laurent Pinchart <[email protected]> > > > + type = "a"; > > + > > + port { > > + hdmi0_con: endpoint { > > + remote-endpoint = <&rcar_dw_hdmi0_out>; > > + }; > > + }; > > + }; > > + > > leds { > > compatible = "gpio-leds"; > > > > @@ -82,6 +94,30 @@ > > states = <3300000 1 > > 1800000 0>; > > }; > > + > > + x302_clk: x302-clock { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <33000000>; > > + }; > > + > > + x304_clk: x304-clock { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <25000000>; > > + }; > > +}; > > + > > +&du { > > + clocks = <&cpg CPG_MOD 724>, > > + <&cpg CPG_MOD 723>, > > + <&cpg CPG_MOD 722>, > > + <&versaclock5 1>, > > + <&x302_clk>, > > + <&versaclock5 2>; > > + clock-names = "du.0", "du.1", "du.2", > > + "dclkin.0", "dclkin.1", "dclkin.2"; > > + status = "okay"; > > }; > > > > &ehci0 { > > @@ -109,11 +145,37 @@ > > }; > > }; > > > > +&hdmi0 { > > + status = "okay"; > > + > > + ports { > > + port@1 { > > + reg = <1>; > > + rcar_dw_hdmi0_out: endpoint { > > + remote-endpoint = <&hdmi0_con>; > > + }; > > + }; > > + }; > > +}; > > + > > &hsusb { > > dr_mode = "otg"; > > status = "okay"; > > }; > > > > +&i2c4 { > > + clock-frequency = <400000>; > > + status = "okay"; > > + > > + versaclock5: clock-generator@6a { > > + compatible = "idt,5p49v5923"; > > + reg = <0x6a>; > > + #clock-cells = <1>; > > + clocks = <&x304_clk>; > > + clock-names = "xin"; > > + }; > > +}; > > + > > &ohci0 { > > status = "okay"; > > }; > > -- > Regards, > > Laurent Pinchart
