> On July 31, 2019 at 3:24 PM Geert Uytterhoeven <[email protected]> > wrote: > > > At the time of commit 9a643c9a11259955 ("sh-pfc: Convert message > printing from pr_* to dev_*"), the dev_*_once() variants didn't exist > yet, so the once behavior was open-coded. > > Since commit e135303bd5bebcd2 ("device: Add dev_<level>_once variants") > they do, so "revert" to the good practice of using a helper. > > Signed-off-by: Geert Uytterhoeven <[email protected]> > --- > To be queued in sh-pfc-for-v5.4. > > drivers/pinctrl/sh-pfc/gpio.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/pinctrl/sh-pfc/gpio.c b/drivers/pinctrl/sh-pfc/gpio.c > index 97c1332c1045739a..64c09aa374ae011f 100644 > --- a/drivers/pinctrl/sh-pfc/gpio.c > +++ b/drivers/pinctrl/sh-pfc/gpio.c > @@ -255,18 +255,13 @@ static int gpio_pin_setup(struct sh_pfc_chip *chip) > #ifdef CONFIG_PINCTRL_SH_FUNC_GPIO > static int gpio_function_request(struct gpio_chip *gc, unsigned offset) > { > - static bool __print_once; > struct sh_pfc *pfc = gpio_to_pfc(gc); > unsigned int mark = pfc->info->func_gpios[offset].enum_id; > unsigned long flags; > int ret; > > - if (!__print_once) { > - dev_notice(pfc->dev, > - "Use of GPIO API for function requests is > deprecated." > - " Convert to pinctrl\n"); > - __print_once = true; > - } > + dev_notice_once(pfc->dev, > + "Use of GPIO API for function requests is deprecated, > convert to pinctrl\n"); > > if (mark == 0) > return -EINVAL; > -- > 2.17.1
Reviewed-by: Ulrich Hecht <[email protected]> CU Uli >
