Hi Shimoda-san, On Mon, Jul 29, 2019 at 7:16 AM Yoshihiro Shimoda <[email protected]> wrote: > > From: Linus Walleij, Sent: Monday, July 29, 2019 8:02 AM > > > > On Mon, Jul 8, 2019 at 11:08 AM Yoshihiro Shimoda > > <[email protected]> wrote: > > > > > The old commit c58d9c1b26e3 ("sh-pfc: Implement generic pinconf > > > support") broke the cfg->type flag to PINMUX_TYPE_FUNCTION because > > > sh_pfc_pinconf_set() didn't call sh_pfc_reconfig_pin(). > > > Now if we fix the cfg->type condition, it gets worse because: > > > - Some drivers might be deferred so that .set_mux() will be called > > > multiple times. > > > - In such the case, the sh-pfc driver returns -EBUSY even if > > > the group is the same, and then that driver fails to probe. > > > > > > Since the pinctrl subsystem already has such conditions according > > > to @set_mux and @gpio_request_enable, this patch just remove > > > the incomplete flag from sh-pfc/pinctrl.c. > > > > > > Signed-off-by: Yoshihiro Shimoda <[email protected]> > > > > This looks like it should have a Fixes: tag as well. > > I got it. The Fixes tag should be: > > Fixes: c58d9c1b26e3 ("sh-pfc: Implement generic pinconf support")
Reviewed-by: Geert Uytterhoeven <[email protected]> > > Geert will decide what to do with this. > > I got it. > > > Can all the pinctrl patches be applied independently of the other > > changes so Geert can apply and send me those patches in his pull > > requests? > > The pinctrl patches (1/7 through 3/7) can be applied on next-20190726 > so I think Geert can apply these patches into his repo. Looks mostly OK to me (I have some comments on 3/7). I'll apply it to my local tree, so it will receive some testing on all boards I have. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
