Hi Shimoda-san,
Thanks a lot for your feedback.
On Wed, Sep 04, 2019 at 12:08:39PM +0000, Yoshihiro Shimoda wrote:
> Hi Veeraiyan,
>
> Thank you very much for the patch! I didn't realize that using
> USB_INT_1_B2_SPND
> can resolve such a behavior. I'd like to apply this patch into upstream, but
> I have some comments below.
>
> > From: Veeraiyan Chidambaram, Sent: Wednesday, September 4, 2019 6:24 PM
> >
> > In RCAR3 USB 3.0 Function, if host is detached an interrupt
>
> I'd like to replace "RCAR3" with "R-Car Gen3".
Yes . I agree
> > Without this commit, disconnection of the phone from R-Car-H3 ES2.0
>
> s/R-Car-H3/R-Car H3/
Yes . I agree
> IIUC, reverse role switch will happen by a user space application.
> Is it correct?
Yes, understanding is correct and made the change in commit message.
> I'd like to change the conditions like below if it still works on your
> environment.
> This is because I'd like to set the gadget state if other gadget driver
> except f_fs
> is used anyway. After that, a user also can recognize the state by using
> /sys/devices/platform/soc/ee020000.usb/udc/ee020000.usb/state even if the use
> doesn't use f_fs driver.
>
> if (usb3->gadget.speed != USB_SPEED_UNKNOWN &&
> usb3->gadget.state != USB_STATE_NOTATTACHED) {
> if (usb3->driver && usb3->driver->suspend)
> usb3->driver->suspend(&usb3->gadget);
> usb_gadget_set_state(&usb3->gadget, USB_STATE_SUSPENDED);
> }
Above change worked in our environment. I prepare patch for this
> Best regards,
> Yoshihiro Shimoda
>
