On Mon, Sep 02, 2019 at 08:41:14PM +0300, Sergei Shtylyov wrote: > On 09/02/2019 11:06 AM, Simon Horman wrote: > > > From: Kazuya Mizuguchi <[email protected]> > > > > This patch removes the use of the undocumented registers > > CDCR, LCCR, CERCR, CEECR and the undocumented BOC bit of the CCC register. > > The driver has many more #define's marked as undocumented. It's not clear > why you crammed the counters and the endianness bit in one patch. It clearly > needs to be split -- one patch for the MAC counters and one patch for the > AVB-DMAC bit.
Thanks for the suggestion, I will split the patch. > > Current documentation for EtherAVB (ravb) describes the offset of > > what the driver uses as the BOC bit as reserved and that only a value of > > 0 should be written. Furthermore, the offsets used for the undocumented > > registers are also considered reserved nd should not be written to. > > > > After some internal investigation with Renesas it remains unclear > > why this driver accesses these fields but regardless of what the historical > > reasons are the current code is considered incorrect. > > > > Signed-off-by: Kazuya Mizuguchi <[email protected]> > > Signed-off-by: Simon Horman <[email protected]> > [...] > > MBR, Sergei >
